Example react native test app #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-native-test-app
…janaRao/segmented-control into example-react-native-test-app
|
Awesome! Will review soon |
Naturalclar
requested changes
Oct 16, 2022
There was a problem hiding this comment.
@YajanaRao
Thanks for the changes! CI seems to be failing, so could you make the following changes?
- run
yarn lint --fixto apply fix for lint error - in
ci.ymlfile, underandroid:, add a step to install and build packages in the example directory after yarn install
it should look like this:
- name: Install Dependencies
run: yarn
- name: Install Example Dependencies
run: cd example && yarn
- name: Build android
run: cd example && yarn build:android
- name: Build Android Example App and Library
run: cd example/android && ./gradlew clean assembleDebug
- also in
ci.ymlfile, underios:, add a step to install and build packages in the example directory after yarn install
- name: Install Dependencies
run: yarn
- name: Install Example
run: cd example && yarn
- name: Build ios
run: cd example && yarn build:ios
- name: Pod install
run: cd example && pod install --project-directory=ios
- name: Run ios app
run: cd example && yarn ios
|
@Naturalclar I have done the changes you requested. |
Naturalclar
requested changes
Oct 17, 2022
There was a problem hiding this comment.
@YajanaRao thanks for the changes!
sorry, there was one more fix that needed to be done.
the default java version in ci is 8, but current android build required java 11, so android job needs to be set up to use java 11.
Could you add actions/setup-java in the ci and make it use java 11?
setup should look something like this:
android:
runs-on: ubuntu-18.04
strategy:
matrix:
node-version: [16]
java-version: [11]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ matrix.java-version }}
Naturalclar
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
@YajanaRao awesome! thanks again for the fixes. merging this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #583
Updated example project with react native test app. Re used App.js code. 1.4.6 was the version for react native 0.63.
Link to discussion: microsoft/react-native-test-app#1155
Test Plan